Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: avoid slicesgrow in the buildDataSource #58853

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

planner: avoid slicesgrow in the buildDataSource #58853

wants to merge 3 commits into from
+5 −4

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 10, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58842

Problem Summary:

What changed and how does it work?

tidb/pkg/planner/core/logical_plan_builder.go

Lines 4648 to 4658 in cd9d3c0

extraCol := ds.NewExtraHandleSchemaCol()
handleCols = util.NewIntHandleCols(extraCol)
ds.Columns = append(ds.Columns, model.NewExtraHandleColInfo())
schema.Append(extraCol)
names = append(names, &types.FieldName{
DBName: dbName,
TblName: tableInfo.Name,
ColName: model.ExtraHandleName,
OrigColName: model.ExtraHandleName,
})
ds.TblCols = append(ds.TblCols, extraCol)

here is the root causion of the slices grow. so we should add 1 to the capacity of column

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked labels Jan 10, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hawkingrei, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/planner SIG: Planner and removed do-not-merge/needs-tests-checked labels Jan 10, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5271%. Comparing base (d9dc3f4) to head (f6dc16a).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58853        +/-   ##
================================================
+ Coverage   73.1123%   73.5271%   +0.4147%     
================================================
  Files          1677       1677                
  Lines        463901     463962        +61     
================================================
+ Hits         339169     341138      +1969     
+ Misses       103885     101972      -1913     
- Partials      20847      20852         +5
Flag Coverage Δ
integration 42.8314% <100.0000%> (?)
unit 72.2970% <100.0000%> (-0.0020%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7509% <ø> (+0.0209%) ⬆️

@hawkingrei
remove rules
051c384 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
remove rules
f6dc16a 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
Copy link
Member Author

/retest

winoros
winoros reviewed Jan 13, 2025
View reviewed changes
pkg/planner/core/logical_plan_builder.go
@@ -4594,6 +4594,7 @@ func (b *PlanBuilder) buildDataSource(ctx context.Context, tn *ast.TableName, as
}
}
}
countCnt := len(columns) + 1 // +1 for an extra handle column
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we need an intest.Assert for the if block at line#4643 to make sure that clustered index should not be added as the extra one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove gowslices in the (*PlanBuilder).buildDataSource
2 participants
@hawkingrei @winoros